JingsongLi commented on a change in pull request #16:
URL: https://github.com/apache/flink-table-store/pull/16#discussion_r808688217
##########
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/manifest/ManifestCommittable.java
##########
@@ -27,26 +27,26 @@
import java.util.List;
import java.util.Map;
import java.util.Objects;
+import java.util.UUID;
/** Manifest commit message. */
public class ManifestCommittable {
+ private final String uuid;
private final Map<BinaryRowData, Map<Integer, List<SstFileMeta>>> newFiles;
-
private final Map<BinaryRowData, Map<Integer, List<SstFileMeta>>>
compactBefore;
-
private final Map<BinaryRowData, Map<Integer, List<SstFileMeta>>>
compactAfter;
public ManifestCommittable() {
- this.newFiles = new HashMap<>();
- this.compactBefore = new HashMap<>();
- this.compactAfter = new HashMap<>();
+ this(UUID.randomUUID().toString(), new HashMap<>(), new HashMap<>(),
new HashMap<>());
}
public ManifestCommittable(
+ String uuid,
Review comment:
Can we use checkpoint id here? Just like
https://github.com/apache/flink-table-store/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
