LadyForest commented on a change in pull request #20:
URL: https://github.com/apache/flink-table-store/pull/20#discussion_r808775969
##########
File path:
flink-table-store-core/src/main/java/org/apache/flink/table/store/sink/SinkRecord.java
##########
@@ -31,20 +31,15 @@
private final int bucket;
- private final RowKind rowKind;
-
private final BinaryRowData key;
private final RowData row;
- public SinkRecord(
- BinaryRowData partition, int bucket, RowKind rowKind,
BinaryRowData key, RowData row) {
+ public SinkRecord(BinaryRowData partition, int bucket, BinaryRowData key,
RowData row) {
Review comment:
Nit: If the`rowKind` is removed from `SinkRecord`, we'd better update
the comment as well.
```
/** A sink record contains key, value and partition, bucket information. */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
