matriv commented on a change in pull request #18804:
URL: https://github.com/apache/flink/pull/18804#discussion_r808802789
##########
File path: docs/content/docs/dev/table/tableApi.md
##########
@@ -1454,21 +1454,23 @@ result3 =
table.order_by(table.a.asc).offset(10).fetch(5)
{{< label Batch >}} {{< label Streaming >}}
-Similar to the `INSERT INTO` clause in a SQL query, the method performs an
insertion into a registered output table. The `executeInsert()` method will
immediately submit a Flink job which execute the insert operation.
+Similar to the `INSERT INTO` clause in a SQL query, the method performs an
insertion into a registered output table.
+The `insertInto()` method will translate the `INSERT INTO` to a
`TablePipeline`.
Review comment:
maybe `convert` is better than `translate`?
##########
File path: docs/content/docs/dev/table/common.md
##########
@@ -750,9 +763,9 @@ A query is internally represented as a logical query plan
and is translated in t
A Table API or SQL query is translated when:
* `TableEnvironment.executeSql()` is called. This method is used for executing
a given statement, and the sql query is translated immediately once this method
is called.
-* `Table.executeInsert()` is called. This method is used for inserting the
table content to the given sink path, and the Table API is translated
immediately once this method is called.
+* `Table.insertInto()` is called. This method is used for translating an
insertion of the table content to the given sink path into a `TablePipeline`,
and the Table API is translated immediately once this method is called. Using
`TablePipeline.execute()` will execute the pipeline.
Review comment:
`translating` -> `converting`, but not insisting, it's personal opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
