zentol commented on a change in pull request #18815:
URL: https://github.com/apache/flink/pull/18815#discussion_r808927643
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-pulsar/src/test/java/org/apache/flink/tests/util/pulsar/PulsarSourceOrderedE2ECase.java
##########
@@ -29,11 +29,15 @@
import org.apache.flink.tests.util.pulsar.cases.FailoverSubscriptionContext;
import
org.apache.flink.tests.util.pulsar.common.FlinkContainerWithPulsarEnvironment;
import
org.apache.flink.tests.util.pulsar.common.PulsarContainerTestEnvironment;
+import org.apache.flink.testutils.junit.FailsOnJava11;
+
+import org.junit.experimental.categories.Category;
/**
* Pulsar E2E test based on connector testing framework. It's used for
Failover & Exclusive
* subscription.
*/
+@Category(value = {FailsOnJava11.class})
Review comment:
Why not just add a dependency on jaxb-api in the Java 11 profile?...
Actually, why is this necessary at all if we copy the jaxb-api jar in the
pom?
##########
File path: flink-connectors/flink-sql-connector-pulsar/pom.xml
##########
@@ -69,6 +69,7 @@ under the License.
<include>org.bouncycastle:bcprov-jdk15on</include>
<include>org.bouncycastle:bcutil-jdk15on</include>
<include>org.slf4j:jul-to-slf4j</include>
+
<include>javax.xml.bind:jaxb-api</include>
Review comment:
FYI: flink-dist bundles jaxb-api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
