XComp commented on a change in pull request #18806:
URL: https://github.com/apache/flink/pull/18806#discussion_r808954379
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -776,7 +776,7 @@ function expect_in_taskmanager_logs {
local expected="$1"
local timeout=$2
local i=0
- local logfile="$FLINK_LOG_DIR/flink*taskexecutor*log"
Review comment:
updated that one as well
##########
File path: flink-end-to-end-tests/test-scripts/test_pyflink.sh
##########
@@ -223,13 +223,23 @@ function read_msg_from_kafka {
}
function cat_jm_logs {
- local log_file_name=${3:-standalonesession}
- cat $FLINK_LOG_DIR/*$log_file_name*.log
+ cat_logs_in_order "standalonesession"
}
function cat_tm_logs {
- local logfile="$FLINK_LOG_DIR/flink*taskexecutor*log"
- cat ${logfile}
+ cat_logs_in_order "flink*taskexecutor"
+}
+
+function cat_logs_in_order {
Review comment:
Essentially, I pinged you on that change to have another look whether
it's reasonable since I introduced a new more general function to cover the two
implementations above
##########
File path: flink-end-to-end-tests/test-scripts/queryable_state_base.sh
##########
@@ -25,7 +25,7 @@ function link_queryable_state_lib {
# Returns the ip address of the queryable state server
function get_queryable_state_server_ip {
- local ip=$(cat $FLINK_LOG_DIR/flink*taskexecutor*log \
Review comment:
updated that one as well
##########
File path: flink-end-to-end-tests/test-scripts/queryable_state_base.sh
##########
@@ -35,7 +35,7 @@ function get_queryable_state_server_ip {
# Returns the ip address of the queryable state server
function get_queryable_state_proxy_port {
- local port=$(cat $FLINK_LOG_DIR/flink*taskexecutor*log \
Review comment:
updated that one as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
