dawidwys commented on a change in pull request #18745:
URL: https://github.com/apache/flink/pull/18745#discussion_r809033623
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java
##########
@@ -217,18 +207,11 @@ public void start() throws Exception {
@Override
public void close() throws Exception {
LOG.info("Closing SourceCoordinator for source {}.", operatorName);
- try {
- if (started) {
- context.close();
- if (enumerator != null) {
- enumerator.close();
- }
+ if (started) {
+ closeQuietly(context);
Review comment:
I get that. Is it mandatory that we do not have any exceptions? Or just
that if an exception is thrown in `context.close` we continue with
`enumerator.close`. That's what `closeAll` does. The difference is though at
the end it will throw the exception from the `context#close` and if both
`context.close` and `enumerator.close` throw the second one will be thrown with
the first as suppressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
