zentol commented on a change in pull request #18689:
URL: https://github.com/apache/flink/pull/18689#discussion_r809064452
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepoint.java
##########
@@ -178,27 +168,6 @@ private void completeOperationAndGoToFinished(String
savepoint) {
context.goToFinished(ArchivedExecutionGraph.createFrom(getExecutionGraph()));
}
- private void handleAnyFailure(Throwable cause) {
- operationFailureCause = cause;
Review comment:
Are you sure this is safe? I don't know if there's a guarantee that the
savepoint future is completed (exceptionally) before the state is notified of a
task failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
