matriv commented on a change in pull request #18813:
URL: https://github.com/apache/flink/pull/18813#discussion_r809073882
##########
File path: docs/content/docs/dev/table/types.md
##########
@@ -1487,6 +1479,86 @@ Not supported.
{{< /tab >}}
{{< /tabs >}}
+Casting
+-------
+
+Flink SQL can perform casting between a defined tuple `from` type and `target`
type.
+While some casting operations can always succeed no matter the input value,
others can fail at runtime,
Review comment:
What you have added sounds good, thx!
##########
File path: docs/content/docs/dev/table/types.md
##########
@@ -1482,15 +1484,15 @@ Not supported.
Casting
-------
-Flink SQL can perform casting between a defined tuple `from` type and `target`
type.
+Flink SQL can perform casting between a defined pair `from` type and `target`
type.
While some casting operations can always succeed no matter the input value,
others can fail at runtime,
-that is for some input values there is no way to construct an instance of the
target type.
+that is, for some input values there is no way to create a value for the
target type.
For example, it's always possible to convert `INT` to `STRING`, but viceversa
is not true,
as you can provide an input `STRING` which cannot be converted to `INT`, like
`'abc'`.
-Flink SQL validates and rejects queries which cast tuples are invalid,
+Flink SQL during planning rejects queries which cast pairs are invalid with a
`ValidationException`,
Review comment:
`Flink SQL, during planning, rejects....` (add the 2 commas)
##########
File path: docs/content/docs/dev/table/types.md
##########
@@ -1548,14 +1550,16 @@ Also note that a cast of a `NULL` value will always
return `NULL`, no matter the
### Legacy casting
Pre Flink 1.15 casting behaviour can be enabled by setting
`table.exec.legacy-cast-behaviour` to `enabled`.
+In Flink 1.1 this flag is enabled by default.
Review comment:
`Flink 1.15`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
