becketqin commented on a change in pull request #18745:
URL: https://github.com/apache/flink/pull/18745#discussion_r809133223
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java
##########
@@ -259,9 +265,9 @@ public void runInCoordinatorThread(Runnable runnable) {
@Override
public void close() throws InterruptedException {
closed = true;
- notifier.close();
- coordinatorExecutor.shutdown();
- coordinatorExecutor.awaitTermination(Long.MAX_VALUE,
TimeUnit.MILLISECONDS);
+ // Close quietly so the closing sequence will be executed completely.
+ closeQuietly(notifier);
Review comment:
I see. However, here I feel it is slightly more readable to just
shutdown the two executors explicitly. It seems quite simple and straight
forward compared with constructing two `AutoClosables` and invoke `closeAll()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
