[
https://issues.apache.org/jira/browse/FLINK-24677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494341#comment-17494341
]
Caizhi Weng edited comment on FLINK-24677 at 2/18/22, 3:12 AM:
---------------------------------------------------------------
Hi [~2011aad]!
You should first fix it in the master branch. After a committer has approved
they'll help you apply your fix to other branches (if it can be cherry-picked
directly) or ask you to submit fixes to other branches. In general, the fix
should be applied to the latest 3 versions (namely Flink 1.13 ~ Flink 1.15).
No worries about that message as we've discussed that you're taking this issue
in this ticket. I've reviewed your PR and your next step should be adding tests
and changes addressing my comments, or if you don't want to make a change,
reply to my comments and state the reasons.
was (Author: tsreaper):
Hi [~2011aad]!
No worries about that message as we've discussed that you're taking this issue
in this ticket. I've reviewed your PR and your next step should be adding tests
and changes addressing my comments, or if you don't want to make a change,
reply to my comments and state the reasons.
> JdbcBatchingOutputFormat should not generate circulate chaining of exceptions
> when flushing fails in timer thread
> -----------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-24677
> URL: https://issues.apache.org/jira/browse/FLINK-24677
> Project: Flink
> Issue Type: Bug
> Components: Connectors / JDBC
> Affects Versions: 1.15.0
> Reporter: Caizhi Weng
> Priority: Major
> Labels: pull-request-available
>
> This is reported from the [user mailing
> list|https://lists.apache.org/thread.html/r3e725f52e4f325b9dcb790635cc642bd6018c4bca39f86c71b8a60f4%40%3Cuser.flink.apache.org%3E].
> In the timer thread created in {{JdbcBatchingOutputFormat#open}},
> {{flushException}} field will be recorded if the call to {{flush}} throws an
> exception. This exception is used to fail the job in the main thread.
> However {{JdbcBatchingOutputFormat#flush}} will also check for this exception
> and will wrap it with a new layer of runtime exception. This will cause a
> super long stack when the main thread finally discover the exception and
> fails.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
