zentol commented on a change in pull request #18544:
URL: https://github.com/apache/flink/pull/18544#discussion_r810062760
##########
File path:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/Pojo.java
##########
@@ -18,26 +18,31 @@
package org.apache.flink.streaming.connectors.cassandra;
import com.datastax.driver.mapping.annotations.Column;
-import com.datastax.driver.mapping.annotations.Table;
import java.io.Serializable;
-/** Test Pojo with DataStax annotations used. */
-@Table(keyspace = "flink", name = "test")
+/**
+ * Test Pojo with DataStax annotations created dynamically. This class does
not use primitive types
+ * and use public fields because it is manipulated via reflection through a
subclass created by
+ * ByteBuddy.
+ */
public class Pojo implements Serializable {
private static final long serialVersionUID = 1038054554690916991L;
@Column(name = "id")
- private String id;
+ public String id;
@Column(name = "counter")
- private int counter;
+ public Integer counter;
Review comment:
Why don't you use Integer.TYPE for the constructor like I did in the
prototype?
##########
File path:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/Pojo.java
##########
@@ -18,26 +18,31 @@
package org.apache.flink.streaming.connectors.cassandra;
import com.datastax.driver.mapping.annotations.Column;
-import com.datastax.driver.mapping.annotations.Table;
import java.io.Serializable;
-/** Test Pojo with DataStax annotations used. */
-@Table(keyspace = "flink", name = "test")
+/**
+ * Test Pojo with DataStax annotations created dynamically. This class does
not use primitive types
+ * and use public fields because it is manipulated via reflection through a
subclass created by
+ * ByteBuddy.
+ */
public class Pojo implements Serializable {
private static final long serialVersionUID = 1038054554690916991L;
@Column(name = "id")
- private String id;
+ public String id;
@Column(name = "counter")
- private int counter;
+ public Integer counter;
Review comment:
I also don't think they need to be public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
