slinkydeveloper commented on a change in pull request #18847:
URL: https://github.com/apache/flink/pull/18847#discussion_r810115003
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/InternalMiniClusterExtension.java
##########
@@ -26,11 +26,16 @@
import java.net.URI;
-/** An extension which starts a {@link MiniCluster} for testing purposes. */
-public class MiniClusterExtension implements CustomExtension {
+/**
+ * An extension which starts a {@link MiniCluster} for testing purposes.
+ *
+ * <p>This should only be used by tests within the flink-runtime module. Other
modules should use
+ * {@code MiniClusterExtension} provided by flink-test-utils module.
+ */
+public class InternalMiniClusterExtension implements CustomExtension {
Review comment:
What do you mean by wrapping?
I see this `InternalMiniClusterExtension` is used in 2 places: here
`TaskCancelAsyncProducerConsumerITCase` it's wrapped with the
`AllCallbackWrapper` and `AbstractHAJobRunITCase` with the
`EachCallbackWrapper`. Perhaps we need to rework `AbstractHAJobRunITCase` first
to not rely on the extension, since it runs one cluster per method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
