XComp commented on a change in pull request #18751:
URL: https://github.com/apache/flink/pull/18751#discussion_r810136041
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/ZooKeeperCheckpointIDCounterITCase.java
##########
@@ -36,16 +37,21 @@
*/
public class ZooKeeperCheckpointIDCounterITCase extends
CheckpointIDCounterTestBase {
- private static final ZooKeeperTestEnvironment ZooKeeper = new
ZooKeeperTestEnvironment(1);
+ private static ZooKeeperTestEnvironment zookeeper;
+
+ @BeforeClass
+ public static void setUp() throws Exception {
Review comment:
> But if for example we'd add a junit retry to the test it would also
start failing afaik.
Makes sense. I tried it out of curiosity: Interestingly, reverting the
`@BeforeAll` annotated `setUp` method and doing the instantiation in the member
variable declaration still works even when using `@RepeatedTest` on one of the
tests still works 🤔
Anyway, it's looks more consistent 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
