[
https://issues.apache.org/jira/browse/FLINK-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420766#comment-15420766
]
ASF GitHub Bot commented on FLINK-4383:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2365#discussion_r74737803
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/messages/RemoteRpcInvocation.java
---
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rpc.akka.messages;
+
+import org.apache.flink.util.Preconditions;
+import org.apache.flink.util.SerializedValue;
+
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
+import java.io.Serializable;
+
+/**
+ * Remote rpc invocation message which is used when the actor
communication is remote and, thus, the
+ * message has to be serialized.
+ * <p>
+ * In order to fail fast and report an appropriate error message to the
user, the method name, the
+ * parameter types and the arguments are eagerly serialized. In case the
the invocation call
+ * contains a non-serializable object, then an {@link IOException} is
thrown.
+ */
+public class RemoteRpcInvocation implements RpcInvocation, Serializable {
+ private static final long serialVersionUID = 6179354390913843809L;
+
+ // Serialized invocation data
+ private final SerializedValue<RemoteRpcInvocation.MethodInvocation>
serializedMethodInvocation;
+
+ // Transient field which is lazily initialized upon first access to the
invocation data
+ private transient RemoteRpcInvocation.MethodInvocation methodInvocation;
+
+ public RemoteRpcInvocation(
+ final String methodName,
+ final Class<?>[] parameterTypes,
+ final Object[] args) throws IOException {
+
+ serializedMethodInvocation = new SerializedValue<>(new
RemoteRpcInvocation.MethodInvocation(methodName, parameterTypes, args));
--- End diff --
You're right. Will add it.
> Check parameters for serializability before sending a remote RpcInvocation
> message
> ----------------------------------------------------------------------------------
>
> Key: FLINK-4383
> URL: https://issues.apache.org/jira/browse/FLINK-4383
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> Before sending a remote {{RpcInvocation}} message we should check that the
> rpc arguments are serializable. If not we should eagerly fail with an
> appropriate exception message.
> If we don't do this, then Akka will silently fail serializing the message
> without telling the user.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
