maxCodeVector opened a new pull request #18854:
URL: https://github.com/apache/flink/pull/18854


   ## What is the purpose of the change
   
   When creating Task Manager (TM) Pod, the fabric client will query the 
Kubernetes deployment to set owner reference for the TM pod. However, repeating 
to querying the deployment each time is unnecessary which will waste a lot of 
time.
   
   This change solves this problem by saving the Kubernetes deployment object 
in memory.
   
   
   ## Brief change log
   
   Save the master deployment reference as a field of Fabric8FlinkKubeClient 
when the method "createTaskManagerPod()" is called for the first time and then 
get it directly in the following invocation.
   
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as:
   
   Fabric8FlinkKubeClientTest#testCreateFlinkTaskManagerPod()
   Fabric8FlinkKubeClientTest#testStopAndCleanupCluster()
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no) no.
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / no) no.
     - The serializers: (yes / no / don't know) no.
     - The runtime per-record code paths (performance sensitive): (yes / no / 
don't know) no.
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) 
no.
     - The S3 file system connector: (yes / no / don't know) no.
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no) no.
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to