[
https://issues.apache.org/jira/browse/FLINK-26216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495290#comment-17495290
]
Biao Geng edited comment on FLINK-26216 at 2/21/22, 2:55 AM:
-------------------------------------------------------------
[~ConradJam] Thanks for you reply! You give a very valuable point and in my
opinion, such straightforward config error should be raised in front instead of
in reconcile phase, just like the target of this
https://issues.apache.org/jira/browse/FLINK-26136 . I will try to finish my
refactor PR with the simple fix of JM HA ASAP and for the validation part, I
think you can either try to take FLINK-26136 or submit a following PR for this
ticket only. I believe both choice will be encouraged by our community.
was (Author: bgeng777):
[~ConradJam] You give a very valuable point and in my opinion, such
straightforward config error should be raised in front instead of in reconcile
phase, just like the target of this
https://issues.apache.org/jira/browse/FLINK-26136 . I will try to finish my
refactor PR with the simple fix of JM HA ASAP and for the validation part, I
think you can either try to take FLINK-26136 or submit a following PR for this
ticket only. I believe both choice will be encouraged by our community.
> Make 'replicas' work in JobManager Spec
> ---------------------------------------
>
> Key: FLINK-26216
> URL: https://issues.apache.org/jira/browse/FLINK-26216
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
> Reporter: Biao Geng
> Priority: Minor
>
> In our flink kubernetes operator's cr, we allow users to set the replica of
> JobManager.
> But in our {{FlinkUtils#getEffectiveConfig}} method, we currently not set
> this value from the yaml file and as a result, the {{replicas}} will not work
> and the default value(i.e. 1) will be applied.
> Though we believe one JM with KubernetesHaService should be enough for most
> HA cases, the {{replicas}} field of JM also makes sense since more than one
> JM can reduce down time and make recovery of JM failure faster.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
