twalthr commented on a change in pull request #18764:
URL: https://github.com/apache/flink/pull/18764#discussion_r810898336
##########
File path:
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
##########
@@ -1711,7 +1711,12 @@ SqlEndStatementSet SqlEndStatementSet() :
/**
* Parse a statement set.
-* END;
+*
+* STATEMENT SET BEGIN (RichSqlInsert();)+ END
+*
+* Note that when using this parser directive with OrderedQueryOrExpr,
+* you might have choice conflicts because STATEMENT is not a reserved keyword,
Review comment:
Can we make it a reserved keyword? I don't see a reason why not. We have
many reserved keywords and users can simply escape them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]