zentol commented on a change in pull request #18825:
URL: https://github.com/apache/flink/pull/18825#discussion_r810967303
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSinkWriterMetricGroup.java
##########
@@ -35,12 +35,20 @@
implements SinkWriterMetricGroup {
private final Counter numRecordsOutErrors;
+ private final Counter numRecordsWritten;
+ private final Counter numBytesWritten;
private final OperatorIOMetricGroup operatorIOMetricGroup;
private InternalSinkWriterMetricGroup(
MetricGroup parentMetricGroup, OperatorIOMetricGroup
operatorIOMetricGroup) {
super(parentMetricGroup);
numRecordsOutErrors =
parentMetricGroup.counter(MetricNames.NUM_RECORDS_OUT_ERRORS);
+ numRecordsWritten =
+ parentMetricGroup.counter(
+
org.apache.flink.runtime.metrics.MetricNames.IO_NUM_RECORDS_OUT);
Review comment:
> Second question, What do you mean "never exported"? Is there anything
else should be done to make it be exported? Do we have tech guide somewhere?
With that I mean that the metric will never be passed to a reporter. You
can't work your way around that, beyond solving the issue of registering 2
metrics with the same name on the same group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
