[
https://issues.apache.org/jira/browse/FLINK-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421050#comment-15421050
]
ASF GitHub Bot commented on FLINK-4373:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2370#discussion_r74769608
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.clusterframework.types;
+
+import java.io.Serializable;
+
+public class ResourceProfile implements Serializable {
+
+ private static final long serialVersionUID = -784900073893060124L;
+
+ /** How many cpu cores are needed, use double so we can specify cpu
like 0.1 */
+ private final double cpuCores;
+
+ /** How many memory in mb are needed */
+ private final long memoryInMB;
+
+ public ResourceProfile(double cpuCores, long memoryInMB) {
+ this.cpuCores = cpuCores;
+ this.memoryInMB = memoryInMB;
+ }
+
+ /**
+ * Check whether required resource profile can be matched
+ *
+ * @param required the required resource profile
+ * @return true if the requirement is matched, otherwise false
+ */
+ public boolean matchRequirement(ResourceProfile required) {
--- End diff --
Maybe we could rename this method to `isMatching` or
`isMatchingRequirement`. Starting these kind of methods with a question
indicates that it does not change the internal state but checks for a certain
condition.
> Introduce SlotID, AllocationID, ResourceProfile
> -----------------------------------------------
>
> Key: FLINK-4373
> URL: https://issues.apache.org/jira/browse/FLINK-4373
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Kurt Young
> Assignee: Kurt Young
>
> For the new version of cluster management, we need some more basic data
> structures:
> * SlotID: Identifier of one single slot located in a task executor
> * AllocationID: Slot allocation identifier, created by the JobManager when
> requesting a slot, constant across re-tries. Used to identify responses by
> the ResourceManager and to identify deployment calls towards the TaskManager
> that was allocated from.
> * ResourceProfile: The resource profile of the desired slot (currently only
> cpu cores and memory are supported
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
