ruanhang1993 edited a comment on pull request #18847: URL: https://github.com/apache/flink/pull/18847#issuecomment-1047904508
@slinkydeveloper , Thanks for your work. `MiniClusterWithClientExtension` is aimed to replace the Junit 4 rule `MiniClusterWithClientResource` for Junit 5 miguration. The same is the `MiniClusterExtension` for `MiniClusterResource`. Because of some unresolved discussions, these extensions are only used in one or two classes as an example. The `MiniClusterWithClientResource` rule could be used as `@Rule` or `@ClassRule`. In order to resolve conflicts, we introduce each/all wrappers for Junit 5 extensions. Maybe you can search the usages of `MiniClusterWithClientResource`. I think it is better to adapt `@Rule` and `@ClassRule` in Junit 5 when refactoring. To be honest, I don't understand why the `MiniClusterResource` is used as a `@Rule` to start and end a mini cluster for every test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
