CrynetLogistics commented on a change in pull request #18876:
URL: https://github.com/apache/flink/pull/18876#discussion_r812106165
##########
File path:
flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java
##########
@@ -126,11 +126,7 @@ public void test() throws Exception {
generator.sinkTo(kdsSink);
env.execute("Integration Test");
- List<S3Object> objects =
- listBucketObjects(
- createS3Client(mockFirehoseContainer.getEndpoint(),
httpClient),
- BUCKET_NAME);
- assertThat(objects.size()).isEqualTo(NUMBER_OF_ELEMENTS);
+ List<S3Object> objects = listBucketObjects(s3AsyncClient, BUCKET_NAME);
Review comment:
I believe there is an issue in Localstack where it accepts an element
and signals a failure or partial failure including that element. The sink will
therefore retry leading to a duplicate. I notice that in every occurrence of
this issue there is always more elements found than expected.
I have created this follow up
[jira](https://issues.apache.org/jira/browse/FLINK-26305) for a full
investigation into Localstack, but I am happy to modify this test to assert 'at
least once' rather than 'exactly once'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
