echauchot edited a comment on pull request #18610: URL: https://github.com/apache/flink/pull/18610#issuecomment-1047995373
@tillrohrmann There was a change on master since the review started, so I rebased on master: master as moved `coordinatorExecutor` to be a `ScheduledExecutorService`. Now that `coordinatorExecutor` is a `ScheduledExecutorService`, `UncaughtExceptionHandler` is useless as the JVM now uses a `ScheduledFutureTask` that catches exceptions in its `run()` method. We can only get the task Exception through `ScheduledFutureTask#get()`. So `runInCoordinatorThread()` now blocks until the task is done to check its Exceptions and fail the job if there is one. Before it just did a send and forget (did not care about the result of the Future) and could not react to exceptions, so it did not fail the jobManager either. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
