twalthr commented on a change in pull request #18888:
URL: https://github.com/apache/flink/pull/18888#discussion_r812676768
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/match/PatternTranslatorTestBase.scala
##########
@@ -30,6 +30,7 @@ import org.apache.flink.table.data.RowData
import org.apache.flink.table.expressions.Expression
import org.apache.flink.table.planner.calcite.FlinkPlannerImpl
import org.apache.flink.table.planner.delegation.PlannerBase
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeConfiguration
Review comment:
unused?
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/stream/StreamPhysicalGroupWindowAggregateRule.scala
##########
@@ -71,7 +71,8 @@ class StreamPhysicalGroupWindowAggregateRule
val providedTraitSet =
rel.getTraitSet.replace(FlinkConventions.STREAM_PHYSICAL)
val newInput: RelNode = RelOptRule.convert(input, requiredTraitSet)
- val config =
cluster.getPlanner.getContext.unwrap(classOf[FlinkContext]).getTableConfig
+ val config =
+
cluster.getPlanner.getContext.unwrap(classOf[FlinkContext]).getTableConfig.getConfiguration
Review comment:
use `ShortcutUtils`
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/stream/StreamPhysicalGroupWindowTableAggregateRule.scala
##########
@@ -70,7 +70,8 @@ class StreamPhysicalGroupWindowTableAggregateRule
val providedTraitSet =
rel.getTraitSet.replace(FlinkConventions.STREAM_PHYSICAL)
val newInput: RelNode = RelOptRule.convert(input, requiredTraitSet)
- val config =
cluster.getPlanner.getContext.unwrap(classOf[FlinkContext]).getTableConfig
+ val config =
+
cluster.getPlanner.getContext.unwrap(classOf[FlinkContext]).getTableConfig.getConfiguration
Review comment:
use `ShortcutUtils`
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/StreamPhysicalPythonGroupWindowAggregateRule.java
##########
@@ -127,8 +127,12 @@ public RelNode convert(RelNode rel) {
RelTraitSet providedTraitSet =
rel.getTraitSet().replace(FlinkConventions.STREAM_PHYSICAL());
RelNode newInput = RelOptRule.convert(input, requiredTraitSet);
- TableConfig config =
-
cluster.getPlanner().getContext().unwrap(FlinkContext.class).getTableConfig();
+ ReadableConfig config =
Review comment:
`ShortcutUtils`
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/sort/SortCodeGenerator.scala
##########
@@ -19,8 +19,8 @@
package org.apache.flink.table.planner.codegen.sort
import org.apache.flink.table.api.TableConfig
-import org.apache.flink.table.data.{DecimalData, TimestampData}
import org.apache.flink.table.data.binary.BinaryRowData
+import org.apache.flink.table.data.{DecimalData, TimestampData}
Review comment:
move to import commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
