[
https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422210#comment-15422210
]
ASF GitHub Bot commented on FLINK-2055:
---------------------------------------
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r74877942
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java
---
@@ -0,0 +1,371 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.connectors.hbase;
+
+import org.apache.flink.util.Preconditions;
+import org.apache.hadoop.hbase.client.Append;
+import org.apache.hadoop.hbase.client.Delete;
+import org.apache.hadoop.hbase.client.Durability;
+import org.apache.hadoop.hbase.client.Increment;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.client.Put;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * This class represents a list of {@link MutationAction}s you will take
when writing
+ * an input value of {@link HBaseSink} to a row in a HBase table.
+ * Each {@link MutationAction} can create an HBase {@link Mutation}
operation type
+ * including {@link Put}, {@link Increment}, {@link Append} and {@link
Delete}.
+ */
+public class MutationActionList {
+ private final List<MutationAction> actions;
+
+ public MutationActionList() {
+ this.actions = new ArrayList<>();
+ }
+
+ public List<MutationAction> getActions() {
+ return this.actions;
+ }
+
+ /**
+ * Create a new list of HBase {@link Mutation}s.
+ *
+ * @param rowKey row that the created {@link Mutation} list is applied
to
+ * @param writeToWAL enable WAL
+ * @return a list of HBase {@link Mutation}s
+ */
+ public List<Mutation> newMutationList(byte[] rowKey, boolean
writeToWAL) {
+ List<Mutation> mutations = new ArrayList<>();
+ Put put = null;
+ Increment increment = null;
+ Append append = null;
+ Delete delete = null;
+ boolean rowIsDeleted = false;
+ for (MutationAction action : actions) {
+ switch (action.getType()) {
+ case PUT:
+ if (put == null) {
+ put = new Put(rowKey);
+ mutations.add(put);
+ }
+ if (action.getTs() == -1) {
+
put.addColumn(action.getFamily(), action.getQualifier(), action.getValue());
+ } else {
+
put.addColumn(action.getFamily(), action.getQualifier(), action.getTs(),
action.getValue());
+ }
+ break;
+
+ case INCREMENT:
+ if (increment == null) {
+ increment = new
Increment(rowKey);
+ mutations.add(increment);
+ }
+ increment.addColumn(action.getFamily(),
action.getQualifier(), action.getIncrement());
+ break;
+
+ case APPEND:
+ if (append == null) {
+ append = new Append(rowKey);
+ mutations.add(append);
+ }
+ append.add(action.getFamily(),
action.getQualifier(), action.getValue());
+ break;
+
+ // If there are multiple DELETE_ROW actions,
only the first one is served
+ case DELETE_ROW:
+ if (!rowIsDeleted) {
+ for (int i = 0; i <
mutations.size(); ) {
+ if (mutations.get(i)
instanceof Delete) {
+
mutations.remove(i);
+ } else {
+ i++;
+ }
+ }
+ delete = new Delete(rowKey,
action.getTs());
+ mutations.add(delete);
+ rowIsDeleted = true;
+ }
+ break;
+
+ case DELETE_FAMILY:
+ if (!rowIsDeleted) {
+ if (delete == null) {
+ delete = new
Delete(rowKey);
+ mutations.add(delete);
+ }
+
delete.addFamily(action.getFamily(), action.getTs());
+ }
+ break;
+
+ case DELETE_COLUMNS:
+ if (!rowIsDeleted) {
+ if (delete == null) {
+ delete = new
Delete(rowKey);
+ mutations.add(delete);
+ }
+
delete.addColumns(action.getFamily(), action.getQualifier(), action.getTs());
+ }
+ break;
+
+ case DELETE_COLUMN:
+ if (!rowIsDeleted) {
+ if (delete == null) {
+ delete = new
Delete(rowKey);
+ mutations.add(delete);
+ }
+
delete.addColumn(action.getFamily(), action.getQualifier(), action.getTs());
+ }
+ break;
+
+ default:
+ throw new
IllegalArgumentException("Cannot process such action type: " +
action.getType());
+ }
+ }
+ Durability durability = writeToWAL ? Durability.SYNC_WAL :
Durability.SKIP_WAL;
+ for (Mutation mutation : mutations) {
+ mutation.setDurability(durability);
+ }
+ return mutations;
+ }
+
+ /**
+ * Create a new list of HBase {@link Mutation}s enabling WAL as default.
+ *
+ * @param rowKey row that the created {@link Mutation} list is applied
to
+ * @return a list of HBase {@link Mutation}s
+ */
+ public List<Mutation> newMutationList(byte[] rowKey) {
+ return newMutationList(rowKey, true);
--- End diff --
> And would it be even better to make newMutationList(byte[] rowKey,
boolean writeToWAL) a non-public method?
Exactly. That was my point. My below comments also was to make things
cleaner. So MutationActionList is exposed to the user. It should only have
getMutations() or createMutations() and addXXX(). So when the user creates a
MuationActionList using addXXX APIs in it. Then he should do getMutations() or
createMutations()(add suitable javadoc) saying this API gives a list of
mutations that can be sent to HBase. In this method you need to do the logic of
what newMutationList() does. Do not expose getActions() also. I was suggesting
to do this in MutationAction but fine in MutationActionList as only that is
going to be exposed now. Better rename it to MutationActions. Mark
MutationAction inner class Private. And none of those Getters in the inner
class should be exposed to User. If needed you can create it as a separate
class also.
And one important thing, the rowKey() in HBaseMapper decides the row for
which these mutations are getting created. If this is set to null then there is
no MutationActionList possible at all. So you should ensure that the rowKey if
null then the mapper should fail. If not just don''t add any rowKey explicitly
- Anyway actions(IN value) API accepts the rowkey that should be enough.
Inside the impl - if the value is found null throw exception and add a javadoc
about it. It should be enough and will be simple too.
> Implement Streaming HBaseSink
> -----------------------------
>
> Key: FLINK-2055
> URL: https://issues.apache.org/jira/browse/FLINK-2055
> Project: Flink
> Issue Type: New Feature
> Components: Streaming, Streaming Connectors
> Affects Versions: 0.9
> Reporter: Robert Metzger
> Assignee: Hilmi Yildirim
>
> As per :
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Write-Stream-to-HBase-td1300.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
