[
https://issues.apache.org/jira/browse/FLINK-26186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Ge updated FLINK-26186:
----------------------------
Description:
Issue 1:
It seems that the excluding shaded classes filter does not work in this case
since the check is against a valid class whose return type is a shaded external
class which somehow was not handled by the filter. For example, please refer
to FLINK-26174.
Since there is no way to add Flink API annotation to the 3rd party classes, the
rule should be updated.
the main ideas is to extend the rule allow external shaded classes without
Flink API annotation.
Issue 2:
It should be fine to let caller method annotated with @VisibleForTesting call
target method annotated @VisibleForTesting.
was:
It seems that the excluding shaded classes filter does not work in this case
since the check is against a valid class whose return type is a shaded external
class which somehow was not handled by the filter. For example, please refer
to FLINK-26174.
Since there is no way to add Flink API annotation to the 3rd party classes, the
rule should be updated.
the main ideas is to extend the rule allow external shaded classes without
Flink API annotation.
> update the API_ANNOTATIONS rule
> -------------------------------
>
> Key: FLINK-26186
> URL: https://issues.apache.org/jira/browse/FLINK-26186
> Project: Flink
> Issue Type: Improvement
> Reporter: Jing Ge
> Assignee: Jing Ge
> Priority: Major
> Labels: pull-request-available
>
> Issue 1:
> It seems that the excluding shaded classes filter does not work in this case
> since the check is against a valid class whose return type is a shaded
> external class which somehow was not handled by the filter. For example,
> please refer to FLINK-26174.
> Since there is no way to add Flink API annotation to the 3rd party classes,
> the rule should be updated.
> the main ideas is to extend the rule allow external shaded classes without
> Flink API annotation.
>
> Issue 2:
> It should be fine to let caller method annotated with @VisibleForTesting call
> target method annotated @VisibleForTesting.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
