dmvk commented on a change in pull request #18901:
URL: https://github.com/apache/flink/pull/18901#discussion_r813801083
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesStateHandleStore.java
##########
@@ -69,13 +75,72 @@
* the leader could update the store. Then we will completely get rid of the
lock-and-release in
* Zookeeper implementation.
*
- * @param <T> Type of state
+ * @param <T> Type of the state we're storing.
*/
public class KubernetesStateHandleStore<T extends Serializable>
implements StateHandleStore<T, StringResourceVersion> {
private static final Logger LOG =
LoggerFactory.getLogger(KubernetesStateHandleStore.class);
+ private static <T extends Serializable> StateHandleWithDeleteMarker<T>
deserializeStateHandle(
Review comment:
I was thinking about that as well at it seemed way to magic and hard for
a potential reader to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
