dannycranmer commented on a change in pull request #18651:
URL: https://github.com/apache/flink/pull/18651#discussion_r813907696
##########
File path:
flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkWriterTest.java
##########
@@ -74,30 +73,28 @@ public void
getSizeInBytesReturnsSizeOfBlobBeforeBase64Encoding() {
.isEqualTo(testString.getBytes(StandardCharsets.US_ASCII).length);
}
- @Test
+ @Test(expected =
KinesisFirehoseException.KinesisFirehoseFailFastException.class)
Review comment:
If we expect to throw why is there an assertion on the last line of the
test? We should be using assertJ for exception checking
`Assertions.assertThatExceptionOfType(..)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
