XComp commented on a change in pull request #18869:
URL: https://github.com/apache/flink/pull/18869#discussion_r813953362
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStoreTest.java
##########
@@ -954,4 +1212,38 @@ public void testRemoveAllHandlesShouldRemoveAllPaths()
throws Exception {
assertThat(zkStore.getAllHandles(), is(empty()));
}
+
+ @Test
+ public void testGetAllHandlesWithMarkedForDeletionEntries() throws
Exception {
Review comment:
Good point. That's the shortcoming of the `ZooKeeperStateHandleStore`
not collecting the handles in a transaction. But we concluded that it's not
necessary to exclude the deleted once because it can always happen getting the
handles and before utilizing them that the underlying handle was deleted.
I mentioned that already in the `ZooKeeperStateHandleStore` implementation
but extended the `StateHandleStore` JavaDoc accordingly. With the interface
JavaDoc changes, it should be ok to have this being implemented more strictly
in the k8s implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
