pnowojski commented on a change in pull request #18883:
URL: https://github.com/apache/flink/pull/18883#discussion_r814889853



##########
File path: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointTestBase.java
##########
@@ -123,6 +126,20 @@
 
     @Rule public TestName name = new TestName();
 
+    @BeforeClass
+    public static void beforeAll() {
+        // set to some high enough number, it is recommended to have as many 
arenas as slots
+        // If a single buffer pool is shared between all tms we should have 
tms * slots_per_tm
+        // This should be the maximum across all tests run
+        SharedPoolNettyShuffleServiceFactory.bufferPool = new 
NettyBufferPool(60);

Review comment:
       can you encapsulate modifications of this field? At the very least via 
some static methods in `SharedPoolNettyShuffleServiceFactory`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to