Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/2374
  
    I'm not suggesting that they may be useless; my point is that we should not 
copy/use things without questioning whether they fit the bill. To that end I 
simply asked questions that came to mind :)
    
    We now have 1, 5 and 15 minute rates. Are these enough? Do we maybe need 
sub-minute rates? Do we need an hour rate as well? Essentially, why these rates 
and not others? Could the 1 minute rate be enough for us?
    
    For each added rate a given processing overhead is created. Is this 
overhead worth it? Should we force this overhead on every Meter user even if 
they only use a single rate? Should we maybe not hard-code different rates but 
make them configurable (somehow)?
    
    Why do we need an *exponentially weighed* 15 minute rate if you can get a 
closer look at recent events with the 5 minute rate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to