rkhachatryan commented on a change in pull request #18931:
URL: https://github.com/apache/flink/pull/18931#discussion_r816839971
##########
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/RetryingExecutor.java
##########
@@ -172,16 +225,19 @@ private RetriableTask next() {
actionCompleted,
runnable,
retryPolicy,
- executorService,
- attemptsPerTaskHistogram);
+ blockingExecutor,
+ attemptsPerTaskHistogram,
+ scheduler,
+ failureCallback,
+ activeAttempts);
}
private Optional<ScheduledFuture<?>> scheduleTimeout() {
long timeout = retryPolicy.timeoutFor(current);
return timeout <= 0
? Optional.empty()
: Optional.of(
- executorService.schedule(
+ scheduler.schedule(
Review comment:
I think it's the IO, not the timer thread pool that is exhausted. The
test with `maxAttempts=2` succeeds with `nThreads=2` passed to
`RetryingExecutor`.
This happens because `BlockingUploader` in the test waits indefinitely (and
is not interrupted).
Not interrupting is intentional here - the upload should be completed by an
attempt that finishes the first (it can be "timed out" but can still complete
before subsequent attempts).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
