afedulov commented on pull request #18905: URL: https://github.com/apache/flink/pull/18905#issuecomment-1057316151
Thanks for the review, @dmvk, and for spotting this: > I did a quick sanity check for all connector artifacts: >...There seems to be some weird ones, eg.: These were pulled in from the connector's transitive dependencies and packaged because of the "double shading" in the SQL connector distribution. I added exclusions so that the `flink-connector-base` classes are only packaged once. CI is running, let's see if it breaks anything. >I'm also wondering whether we'd be able to add some test (bash based?) for the shaded artifacts, making sure this contract will hold with future changes Would checking that there are no unshaded `org/apache/flink/connector/base/*` classes in the connectors would suffice? What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
