Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2300#discussion_r75112762
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/JobManagerMetricGroup.java
 ---
    @@ -95,6 +96,15 @@ public int numRegisteredJobMetricGroups() {
                return jobs.size();
        }
     
    +   // 
------------------------------------------------------------------------
    +   //  Component Metric Group Specifics
    +   // 
------------------------------------------------------------------------
    +
    +   @Override
    +   protected void putVariables(Map<String, String> variables) {
    +           variables.put(ScopeFormat.SCOPE_ACTOR_HOST, hostname);
    --- End diff --
    
    Can we call this simply `SCOPE_HOST`? The "actor" part is an implementation 
specific detail that should not be part of this abstraction level.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to