PatrickRen commented on a change in pull request #18965:
URL: https://github.com/apache/flink/pull/18965#discussion_r818310017
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
##########
@@ -496,17 +494,4 @@ private void unpause(int brokerId) throws Exception {
pausedBroker.remove(brokerId);
LOG.info("Broker {} is resumed", brokerId);
}
-
- private KafkaConsumer<Void, Void> createTempConsumer() {
- Properties consumerProps = new Properties();
- consumerProps.putAll(getStandardProperties());
- consumerProps.setProperty(
- ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG,
- VoidDeserializer.class.getCanonicalName());
- consumerProps.setProperty(
- ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG,
- VoidDeserializer.class.getCanonicalName());
-
consumerProps.setProperty(ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG,
"false");
- return new KafkaConsumer<>(consumerProps);
- }
Review comment:
Thanks for the reminder! This class has too much warnings (technical
debt) so I didn't notice this one 😞 Maybe we need a giant refactor on Kafka
test utils in the future. They are deeply bound with the legacy
FlinkKafkaProducer and FlinkKafkaConsumer now so a lots of horrible warnings in
IDE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
