dawidwys commented on pull request #18963:
URL: https://github.com/apache/flink/pull/18963#issuecomment-1057827384


   The solution lgtm, would be good to get @rkhachatryan opinion here.
   
   I struggled a bit with the `TestingFileSystem`. I am not the biggest fan of 
the `resetCallbacks` method there. I was wondering if the entire class is not a 
bit an overkill. However, I am good if you think it can be reused in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to