matriv commented on a change in pull request #18972:
URL: https://github.com/apache/flink/pull/18972#discussion_r818810304
##########
File path: docs/layouts/shortcodes/generated/deployment_configuration.html
##########
@@ -12,7 +12,7 @@
<td><h5>execution.allow-client-job-configurations</h5></td>
<td style="word-wrap: break-word;">true</td>
<td>Boolean</td>
- <td>Determines whether configurations in the user program are
allowed when running with Application mode. Has no effect for other deployment
modes.</td>
+ <td>Determines whether configurations in the user program are
allowed. Depending on your deployment mode failing the job might have different
affects. Either your client that is trying to submit the job to an external
cluster (session cluster deployment) throws the exception or the Job manager
(application mode deployment).</td>
Review comment:
I think there bust be an extra space here as well between `session` and
`cluster`
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/DeploymentOptions.java
##########
@@ -112,6 +112,9 @@
.defaultValue(true)
.withDescription(
"Determines whether configurations in the user
program are "
- + "allowed when running with Application
mode. Has no effect for other "
- + "deployment modes.");
+ + "allowed. Depending on your deployment
mode failing the job "
+ + "might have different affects. Either
your client that is "
+ + "trying to submit the job to an external
cluster (session "
+ + " cluster deployment) throws the
exception or the Job "
Review comment:
```suggestion
+ "cluster deployment) throws the
exception or the Job "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
