gaoyunhaii commented on pull request #18805: URL: https://github.com/apache/flink/pull/18805#issuecomment-1059026500
Hi Fabian~ > I would have though combine and `filterRecoveredCommittables` are now equal or very closely to what was done before. It seems currently `filterRecoveredCommittables` and `combine` are used only on the legacy state~? For example, suppose we recovered from sink v1, then on restoring we would call `filterRecoveredCommittables`, then if the job continue running and take another several checkpoints, then after failover all committables are stored in the `CommittableCollector` and on restoring `filterRecoveredCommittables` seems would not be called~? For `endOfInput` it is initially designed to write metas, like write partition to the hive metastore or write `_SUCCESS` file under the directory. I'm also agree with we could change it if no users are using it since it is marked as `Experimental` before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
