echauchot commented on pull request #18610: URL: https://github.com/apache/flink/pull/18610#issuecomment-1059073995
> Thanks @echauchot for the discussion, I think I have most of the context I've been missing. +1 > > Few questions: > > * Do we really need changes to the ManualScheduledExecutor.. ? It doesn't seem to create any threads, because all runnables are executed directly by calling `trigger...`. => agree > * Do we also need to handle failures in `SourceCoordinator#announceCombinedWatermark`? => I guess it is outside of the scope of this PR. But if needed, I could do a second PR. > * We already have the `errorHandlingCoordinatorExecutor`. Could that be reused instead of creating another wrapper? => done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
