XComp opened a new pull request #18979:
URL: https://github.com/apache/flink/pull/18979
## What is the purpose of the change
The various `FileSystem.delete` implementations behave not consistently.
Additionally, (at least) the Presto S3 FileSystem contains a bug in the
recursive delete not propagating the return value properly. This causes issues
with the cleanup which expects a failure if the deletion fails.
This PR limits the function calls to `delete` (not recursively), `exists`
and `listStatus` to workaround the bug in the presto filesystem. Ideally, we
should have a native s3 implementation.
## Brief change log
* Implements `FileSystem.delete(Path, Boolean)` relying on `delete` (not
recursively), `exists` and `listStatus`
## Verifying this change
* Adds tests for `exists` and `delete` to `FileSystemBehaviorTestSuite`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: yes
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? JavaDoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
