fapaul commented on pull request #18805: URL: https://github.com/apache/flink/pull/18805#issuecomment-1059227883
> It seems currently `filterRecoveredCommittables` and `combine` are used only on the legacy state~? For example, suppose we recovered from sink v1, then on restoring we would call `filterRecoveredCommittables`, then if the job continue running and take another several checkpoints, then after failover all committables are stored in the `CommittableCollector` and on restoring `filterRecoveredCommittables` seems would not be called~? I thought about this for a longer time and think the behaviour of `combine` should be fine since it is always used when calling commit. The semantic of `filterRecoveredCommittables` is definitely currently unclear although I would also question the purpose of this method. In general, I think all commit calls be for the committer of global committer need to be idempotent and handling already committed committables needs to happen in the commit method either way. I do not see an immediate benefit of calling `filterRecoveredCommittables`. I am not really what to do about that. Do you have an idea? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
