LadyForest commented on a change in pull request #28:
URL: https://github.com/apache/flink-table-store/pull/28#discussion_r819662125
##########
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/StoreSink.java
##########
@@ -123,22 +191,20 @@ public StoreSink(
});
}
- return new StoreGlobalCommitter<>(
- commit, fileStore.newExpire(), fileCommitSerializer(), lock,
overwritePartition);
+ return new StoreGlobalCommitter(commit, fileStore.newExpire(), lock,
overwritePartition);
}
+ @SuppressWarnings("unchecked")
@Override
public SimpleVersionedSerializer<Committable> getCommittableSerializer() {
- return CommittableSerializer.INSTANCE;
+ return new CommittableSerializer(
+ fileCommitSerializer(), (SimpleVersionedSerializer<Object>)
logCommitSerializer());
}
@Override
- public GlobalCommittableSerializer<LogCommT>
getGlobalCommittableSerializer() {
- ManifestCommittableSerializer fileCommSerializer =
- new ManifestCommittableSerializer(
- project(rowType, partitions), project(rowType, keys),
rowType);
- SimpleVersionedSerializer<LogCommT> logCommitSerializer = new
NoOutputSerializer<>();
- return new GlobalCommittableSerializer<>(logCommitSerializer,
fileCommSerializer);
+ public ManifestCommittableSerializer getGlobalCommittableSerializer() {
+ return new ManifestCommittableSerializer(
+ project(rowType, partitions), project(rowType, keys), rowType);
Review comment:
`new ManifestCommittableSerializer(project(rowType, partitions),
project(rowType, keys), rowType)` can be replaced with `new
ManifestCommittableSerializer(partitionType, KeyType, ValueType)` now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
