[ 
https://issues.apache.org/jira/browse/FLINK-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424584#comment-15424584
 ] 

ASF GitHub Bot commented on FLINK-3839:
---------------------------------------

Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2114
  
    Hi @thormanrd! Thanks for your PR. As Robert and Stephan already pointed 
out, it contains a lot of reformats which are generally encouraged. They make 
the pull request's essentials hard to review and can even introduce subtle 
bugs. 
    
    The prefered way of syncing up with the master is to rebased against the 
master before you open a pull request:
    
    ```
    git pull --rebase upstream master
    ``` 
    `upstream` is the main Flink repository. Maybe it's called `origin` in your 
case. Check using `git remote -v`.
    
    After the pull request has been opened you should only push additional 
commits (no rebasing) to keep the comments and discussion. In the end, either 
you or the committer rebases again.


> Support wildcards in classpath parameters
> -----------------------------------------
>
>                 Key: FLINK-3839
>                 URL: https://issues.apache.org/jira/browse/FLINK-3839
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ken Krugler
>            Assignee: Robert Thorman
>            Priority: Minor
>
> Currently you can only specify a single explict jar with the CLI --classpath 
> file://<path to jar> parameter.Java (since 1.6) has allowed you to use -cp 
> <path to directory>/* as a way of adding every file that ends in .jar in a 
> directory.
> This would simplify things, e.g. when running on EMR you have to add roughly 
> 120 jars explicitly, but these are all located in just two directories.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to