[
https://issues.apache.org/jira/browse/FLINK-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424625#comment-15424625
]
ASF GitHub Bot commented on FLINK-4189:
---------------------------------------
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2380
[FLINK-4189] [table] Introduce symbols for internal use
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
This PR introduces symbols for the Scala/Java Table API. These symbols can
be used e.g. for specifying date/time units or other flags such e.g. for
`TRIM`. To prove the implementation I implemented the `EXTRACT` method from
FLINK-3580.
The PR also contains some refactoring and bug fixes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-4189
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2380.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2380
----
commit 3aeb9b6b967769ac1aa0a5f8c1e2c77fe42746f3
Author: twalthr <[email protected]>
Date: 2016-08-16T12:55:38Z
[FLINK-4189] [table] Introduce symbols for internal use
----
> Introduce symbols for internal use
> ----------------------------------
>
> Key: FLINK-4189
> URL: https://issues.apache.org/jira/browse/FLINK-4189
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
>
> Currently we are using integer values to pass Calcite SQL symbols down to
> code generation. This causes problems like in FLINK-4068. We should support
> symbols internally.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
