lincoln-lil opened a new pull request #19006:
URL: https://github.com/apache/flink/pull/19006
## What is the purpose of the change
FLINK-20370 fix the wrong result when sink primary key is not the same with
query and introduced a new auto-keyby sink's primary key strategy for append
stream if the sink's parallelism differs from input stream's.
But still exists one case to be solved:
for a changelog stream, its changelog upsert key same as sink's primary key,
but sink's parallelism changed by user (via those sinks which implement the
`ParallelismProvider` interface, e.g., KafkaDynamicSink), we should fix it.
And a minor change: keyby canbe omitted when sink has single parallism
(because none partitioner will cause worse disorder)
## Brief change log
update the logic of applyKeyBy in `CommonExecSink`
## Verifying this change
Streaming sql's `TableSinkTest` newly added test cases
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
@Public(Evolving): (no)
- The serializers: (no )
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
