LadyForest opened a new pull request #19007:
URL: https://github.com/apache/flink/pull/19007
## What is the purpose of the change
This PR aims to throw an explicit exception when querying a view with hints
to improve user experience. Currently, the hints on view are swallowed quietly
during the planning phase without any trace, and users complain that the hints
don't work on view.
## Brief changelog
- Add check on `ExpandingPreparingTable` to throw a `ValidationException`
- A monitor fix for `CliClientITCase` to correct the assertion order for
expected and actual
## Verifying this change
This change added tests and can be verified as follows:
- `TableEnvironmentTest#testQueryViewWithHints`
- `OptionHintsTest#testOptionsHintOnTableApiView` and
`#testOptionsHintOnSQLView`
- Add test case in `view.q`, which can be verified by running
`CliClientITCase`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't
know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
