twalthr commented on a change in pull request #18980:
URL: https://github.com/apache/flink/pull/18980#discussion_r822701669
##########
File path:
flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/bridge/scala/internal/StreamTableEnvironmentImpl.scala
##########
@@ -292,6 +294,12 @@ class StreamTableEnvironmentImpl (
object StreamTableEnvironmentImpl {
+ def create(
+ executionEnvironment: StreamExecutionEnvironment,
+ settings: EnvironmentSettings): StreamTableEnvironmentImpl =
+ create(executionEnvironment, settings, TableConfig.getDefault)
+
+ @VisibleForTesting
Review comment:
Let's rework the test then. I don't see a reason why we should make our
internal methods complicated just for a wrongly implemented test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
