zentol commented on a change in pull request #18905:
URL: https://github.com/apache/flink/pull/18905#discussion_r822743640
##########
File path: flink-connectors/flink-sql-connector-kafka/pom.xml
##########
@@ -40,6 +40,12 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-kafka</artifactId>
<version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-connector-base</artifactId>
Review comment:
I guess what could happen is that some other dependency of
connector-kafka may depend on connector-base. However I can't think of a
scenario where we actually want that to result in it being bundled in
downstream projects; as is that'd imply that if users bundle the kafka
connector they'd also bundle connector-base twice.
so TL;DR: That you have to add this exclusion to me implies a larger issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
