slinkydeveloper commented on pull request #19025:
URL: https://github.com/apache/flink/pull/19025#issuecomment-1063131040
There is one pitfall to this PR. If you do `mvn checkstyle:apply` in a
subdirectory project (e.g. `cd flink-scala && mvn spotless:apply`), it will
fail cause it can't find the scalafmt conf. I don't have a good solution for
this, except using `${rootDir}` (which will then won't allow users to do `mvn
checkstyle:apply` anymore). See [this
commit](https://github.com/apache/flink/pull/19025/commits/c390847232844ab360f96483843daa52ef2262ff),
where i disable spotless anyway as there's no need to run it at that phase, as
it's done before during `mvn clean deploy`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
