JingsongLi commented on a change in pull request #31:
URL: https://github.com/apache/flink-table-store/pull/31#discussion_r823271958
##########
File path:
flink-table-store-core/src/test/java/org/apache/flink/table/store/file/TestFileStore.java
##########
@@ -188,6 +191,9 @@ public FileStoreExpireImpl newExpire(int numRetained, long
millisRetained) {
Increment increment =
entryWithBucket.getValue().prepareCommit();
committable.addFileCommittable(
entryWithPartition.getKey(), entryWithBucket.getKey(),
increment);
+ if
(!committable.logOffsets().containsKey(entryWithBucket.getKey())) {
+ committable.addLogOffset(entryWithBucket.getKey(),
ID.getAndIncrement());
Review comment:
Can we just test expected data instead of generation data?
##########
File path:
flink-table-store-core/src/test/java/org/apache/flink/table/store/file/TestFileStore.java
##########
@@ -188,6 +191,9 @@ public FileStoreExpireImpl newExpire(int numRetained, long
millisRetained) {
Increment increment =
entryWithBucket.getValue().prepareCommit();
committable.addFileCommittable(
entryWithPartition.getKey(), entryWithBucket.getKey(),
increment);
+ if
(!committable.logOffsets().containsKey(entryWithBucket.getKey())) {
+ committable.addLogOffset(entryWithBucket.getKey(),
ID.getAndIncrement());
Review comment:
Can we just test expected data instead of generation data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
