Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2315#discussion_r75282731
  
    --- Diff: 
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/StandaloneMesosWorkerStore.java
 ---
    @@ -0,0 +1,87 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.mesos.runtime.clusterframework.store;
    +
    +import com.google.common.collect.ImmutableList;
    +import org.apache.mesos.Protos;
    +import scala.Option;
    +
    +import java.util.LinkedHashMap;
    +import java.util.List;
    +import java.util.Map;
    +
    +/**
    + * A standalone Mesos worker store.
    + */
    +public class StandaloneMesosWorkerStore implements MesosWorkerStore {
    +
    +   private Option<Protos.FrameworkID> frameworkID = Option.empty();
    +
    +   private int taskCount = 0;
    +
    +   private Map<Protos.TaskID, Worker> storedWorkers = new 
LinkedHashMap<>();
    +
    +   public StandaloneMesosWorkerStore() {
    +   }
    +
    +   @Override
    +   public void start() throws Exception {
    +
    +   }
    +
    +   @Override
    +   public void stop() throws Exception {
    +
    +   }
    +
    +   @Override
    +   public Option<Protos.FrameworkID> getFrameworkID() throws Exception {
    +           return frameworkID;
    +   }
    +
    +   @Override
    +   public void setFrameworkID(Option<Protos.FrameworkID> frameworkID) 
throws Exception {
    +           this.frameworkID = frameworkID;
    +   }
    +
    +   @Override
    +   public List<Worker> recoverWorkers() throws Exception {
    +           return ImmutableList.copyOf(storedWorkers.values());
    +   }
    +
    +   @Override
    +   public Protos.TaskID newTaskID() throws Exception {
    +           Protos.TaskID taskID = 
Protos.TaskID.newBuilder().setValue(TASKID_FORMAT.format(++taskCount)).build();
    +           return taskID;
    --- End diff --
    
    Could be simplified: `return 
Protos.TaskID.newBuilder().setValue(TASKID_FORMAT.format(++taskCount)).build();`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to